Skip to content

feat: add scroll-node #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

feat: add scroll-node #14

merged 1 commit into from
Oct 19, 2022

Conversation

colinlyguo
Copy link
Contributor

No description provided.

@colinlyguo colinlyguo changed the title feat: add scroll-node [WIP] feat: add scroll-node Oct 8, 2022
@colinlyguo colinlyguo force-pushed the feat/add-node branch 2 times, most recently from 749562a to 5214aa2 Compare October 9, 2022 16:19
@0xmountaintop
Copy link
Contributor

0xmountaintop commented Oct 10, 2022 •
edited
Loading

  • I think we can still use only 1 go.mod & 1 go.sum & 1 Makefile
    • and probably only 1 Jenkinsfile
  • move build/ under root dir

@colinlyguo colinlyguo closed this Oct 10, 2022
@colinlyguo colinlyguo reopened this Oct 10, 2022
@colinlyguo
Copy link
Contributor Author

  • I think we can still use only 1 go.mod & 1 go.sum & 1 Makefile

    • and probably only 1 Jenkinsfile

  • move build/ under root dir

ok. i will change these files to 1

@0xmountaintop
Copy link
Contributor

BTW, I've changed my mind.

What about we put

cmd/
   |- db_client,go
   |- logger.go
   |- roller/
      |- main.go
   |- bridge/
      |- main.go
      |- flags.go
   |- coordinator/
      |- main.go
      |- flags.go

instead of

|- bridge/
   |- cmd/
|- coordinator/
   |- cmd/
|- roller/
   |- cmd/

?

@colinlyguo
Copy link
Contributor Author

colinlyguo commented Oct 10, 2022 •
edited
Loading

BTW, I've changed my mind.

What about we put

cmd/
   |- db_client,go
   |- logger.go
   |- roller/
      |- main.go
   |- bridge/
      |- main.go
      |- flags.go
   |- coordinator/
      |- main.go
      |- flags.go

instead of

|- bridge/
   |- cmd/
|- coordinator/
   |- cmd/
|- roller/
   |- cmd/

?

yes, it looks more concise, and shares common source files.

@colinlyguo colinlyguo force-pushed the feat/add-node branch 4 times, most recently from ecc0e2e to 5b0440a Compare October 11, 2022 11:27
@colinlyguo colinlyguo force-pushed the feat/add-node branch 3 times, most recently from 155ad06 to 4cb4927 Compare October 12, 2022 04:51
@colinlyguo colinlyguo requested a review from ChuhanJin October 12, 2022 06:59
0xmountaintop
0xmountaintop reviewed Oct 12, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 12, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 12, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 12, 2022
View reviewed changes
@colinlyguo colinlyguo force-pushed the feat/add-node branch 2 times, most recently from b3f24f4 to 72ec430 Compare October 12, 2022 11:32
@colinlyguo colinlyguo mentioned this pull request Oct 12, 2022
Merged
@colinlyguo colinlyguo force-pushed the feat/add-node branch 2 times, most recently from ba15318 to 44500de Compare October 18, 2022 18:18
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
@colinlyguo colinlyguo force-pushed the feat/add-node branch 2 times, most recently from 9c44128 to 01da629 Compare October 19, 2022 04:51
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
0xmountaintop
0xmountaintop reviewed Oct 19, 2022
View reviewed changes
@colinlyguo colinlyguo force-pushed the feat/add-node branch 6 times, most recently from 4bbe191 to 7ded031 Compare October 19, 2022 09:22
@0xmountaintop
feat: add scroll-node
77dd8a9 
chore: move build and common source files to root

feat: add scroll-node new commits (#26)

fix: add Jenkinsfile

chore: test optimize watcher & manager test & misc (scroll-node #199)

change db docker file

remove interface

update go version to 1.18

comb modules

remove useless flag

remove -compat=1.17

remove useless flags

add assets folder

fix flags

move message to common & upgrade go.mod to 1.18

try upgrade lint to go 1.18

remove dummy config

ignore *.go in mock_bridge

revert nolint

revert nolint

fix lint error

fix golint

fix bridge github action

fix abigen

fix abigen

remove database docker interface and cmd

fix CI

fix CI

fix abigen

fix abigen

replace install solc and abigen with actions

fix typos

chore: refactor update sender misc (scroll-node #208)

chore: refactor replace keystore and shadow key in code (scroll-node #211)

fix bug and format config.json
@0xmountaintop 0xmountaintop merged commit dd70cf6 into staging Oct 19, 2022
@0xmountaintop 0xmountaintop deleted the feat/add-node branch October 19, 2022 13:01
@0xmountaintop 0xmountaintop mentioned this pull request Oct 20, 2022
Merged
ChuhanJin pushed a commit that referenced this pull request Mar 15, 2023
@colinlyguo @JJVincentJJ
# This is a combination of 19 commits.
c9c148c 
# This is the 1st commit message:

feat: add monitor metrics (#262)

Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
# This is the commit message #2:

refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #3:

fix: add gas multiplier (#275)


# This is the commit message #4:

feat(libzkp): use dylib instead of staticlib  (#266)

Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: colinlyguo <[email protected]>
# This is the commit message #5:

Revert "fix: add gas multiplier (#275)" (#279)


# This is the commit message #6:

build: add nightly-2022-12-10 rust-related builder image (#282)


# This is the commit message #7:

fix(bridge): compatible with DynamicFeeTxType not supported chain (#280)

Co-authored-by: colinlyguo <[email protected]>
# This is the commit message #8:

feat(contract): enable whitelist relayer (#272)

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #9:

perf(bridge): execute relayer loops independently (#258)

Co-authored-by: colin <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #10:

feat(bridge): confirm block based on "safe" and "finalized" tags (#265)


# This is the commit message #11:

feat: allow to override L2 deployment when address is provided (#293)


# This is the commit message #12:

feat(contracts): Add fee vault (#223)


# This is the commit message #13:

feat(confirmations): Upgrade confirm (#291)


# This is the commit message #14:

feat(coordinator): Enable set ws compression level. (#292)


# This is the commit message #15:

feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: xinran chen <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
# This is the commit message #16:

build: update version to `alpha-v1.0` (#301)


# This is the commit message #17:

feat: import genesis batch during startup (#299)

Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #18:

feat(contracts): new bridge contracts (#288)

Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Thegaram <[email protected]>
Co-authored-by: colin <[email protected]>
# This is the commit message #19:

chore: upgrade l2geth dependency for trace type (#304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuhanJin ChuhanJin Awaiting requested review from ChuhanJin

5 more reviewers

@Lawliet-Chan Lawliet-Chan Lawliet-Chan left review comments

@mask-pp mask-pp mask-pp left review comments

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@scroll-dev scroll-dev scroll-dev approved these changes

@silathdiir silathdiir silathdiir left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@colinlyguo @0xmountaintop @mask-pp @icemelon @Lawliet-Chan @silathdiir @scroll-dev